Migrate channel config request bodies to generated models#6554
Draft
gpunto wants to merge 1 commit into
Draft
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Migrate the channel-config request bodies (
hideChannel,muteChannel/unmuteChannel,updateChannelPartial) to generated models. Part of the incremental OpenAPI model migration.Part of AND-1291
Implementation
internal HideChannelRequest,MuteChannelRequest,UpdateChannelPartialRequestinnetwork.models; delete the hand-written ones. RepointChannelApi,ModerationApi,MoshiChatApi, and tests.MuteChannelRequest: the field is nowchannelCids: List<String>(waschannel_cid: String); bothmuteChannelandunmuteChannelpasslistOf("$type:$id"). Wire payload verified unchanged in behaviour on device.UpdateChannelPartialRequest: generated field order is(unset, set), so the call site now uses named args(set = set, unset = unset).HideChannelRequest:clearHistoryis nowBoolean?(wasBoolean); the call passes it positionally, no logic change.Testing
spotlessApply,apiDump(no API drift),detekt, andtestDebugUnitTestall pass.hideChannel/showChannel->200,muteChannel/unmuteChannel->200, andupdateChannelPartial->200with a custom-field (extraData) round-trip confirmed (sentinel set then unset).